[PATCH] D44817: Fix a block color copying problem in LICM

[Andy Kaylor via Phabricator via llvm-commits]

andrew.w.kaylor added a comment.

In https://reviews.llvm.org/D44817#1046470, @dberlin wrote:

> Sigh.
>  (a quick scan of things named Map in LLVM doesn't find any other obvious cases of this).
>
> I wonder if we shouldn't have a debug/expensive checks mode where it moves all the memory on find and construct to make all these situations fail obviously and  instantly so it could be found by bots.


There used to be a case exactly like this in WinEHPrepare::replaceUseWithLoad(), which is how I knew how to fix this when I saw it crash. The debug mode is a good idea. Could that trigger off of one of the sanitizers somehow?


Repository:
  rL LLVM

https://reviews.llvm.org/D44817