[llvm] r328311 - [GlobalISel] Fix legalizer combine to not use illegal input G_EXTRACT.

Amara Emerson via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 23 05:48:57 PDT 2018


Author: aemerson
Date: Fri Mar 23 05:48:57 2018
New Revision: 328311

URL: http://llvm.org/viewvc/llvm-project?rev=328311&view=rev
Log:
[GlobalISel] Fix legalizer combine to not use illegal input G_EXTRACT.

This was being masked because GISel is enabled by default for -O0 and
the abort was disabled. Modified test to explicitly enable abort.

Modified:
    llvm/trunk/test/CodeGen/AArch64/GlobalISel/legalize-combines.mir

Modified: llvm/trunk/test/CodeGen/AArch64/GlobalISel/legalize-combines.mir
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/GlobalISel/legalize-combines.mir?rev=328311&r1=328310&r2=328311&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/AArch64/GlobalISel/legalize-combines.mir (original)
+++ llvm/trunk/test/CodeGen/AArch64/GlobalISel/legalize-combines.mir Fri Mar 23 05:48:57 2018
@@ -1,5 +1,5 @@
 # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
-# RUN: llc -O0 -run-pass=legalizer -global-isel %s -o - | FileCheck %s
+# RUN: llc -O0 -run-pass=legalizer -global-isel -global-isel-abort=1 %s -o - | FileCheck %s
 
 --- |
   target datalayout = "e-m:o-i64:64-i128:128-n32:64-S128"
@@ -22,7 +22,7 @@ body: |
     ; CHECK: [[ADD:%[0-9]+]]:_(s32) = G_ADD [[COPY]], [[COPY]]
     ; CHECK: [[MV:%[0-9]+]]:_(s64) = G_MERGE_VALUES [[COPY]](s32), [[ADD]](s32)
     ; CHECK: [[EXTRACT:%[0-9]+]]:_(s1) = G_EXTRACT [[MV]](s64), 0
-    ; CHECK: [[EXTRACT1:%[0-9]+]]:_(s64) = G_EXTRACT [[MV]](s64), 0
+    ; CHECK: [[EXTRACT1:%[0-9]+]]:_(s64) = COPY [[MV]](s64)
     %0:_(s32) = COPY $w0
 
     %1:_(s32) = G_ADD %0, %0
@@ -30,7 +30,7 @@ body: |
     %3:_(s1) = G_EXTRACT %2, 0
     %5:_(s32) = G_ANYEXT %3
     $w0 = COPY %5
-    %4:_(s64) = G_EXTRACT %2, 0
+    %4:_(s64) = COPY %2
     $x0 = COPY %4
 ...
 




More information about the llvm-commits mailing list