[PATCH] D44777: Mmap interceptor providing mprotect support

David CARLIER via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 23 00:06:05 PDT 2018


devnexen added inline comments.


================
Comment at: test/sanitizer_common/TestCases/Linux/mmap_write_exec.cpp:20
+  (void)mprotect(q, 64, PROT_WRITE | PROT_EXEC);
+  // CHECK-DISABLED-NOT: WARNING: {{.*}}Sanitizer: writable-executable page usage
+  // CHECK: #0 {{.* ?}}__interceptor_mprotect {{.*}}mmap_write_exec.cpp:[[@LINE-2]]
----------------
vitalybuka wrote:
> there is no point in checking "-NOT:" twice here
> one above covers everything
Oh ok good to know.


https://reviews.llvm.org/D44777





More information about the llvm-commits mailing list