[PATCH] D44810: [PDB] Make LLD PDBs look a little more like Microsoft PDBs

David Majnemer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 22 19:03:45 PDT 2018


majnemer added inline comments.


================
Comment at: llvm/lib/DebugInfo/PDB/Native/PDBStringTableBuilder.cpp:41-47
+  //   int BucketCount = 1;
+  //   int StringCount = 0;
+  //   while (true) {
+  //     ++StringCount;
+  //     if (BucketCount * 3 / 4 < StringCount)
+  //       BucketCount = BucketCount * 3 / 2 + 1;
+  //   }
----------------
This pseudo-code infinite loops. What's the termination condition?


https://reviews.llvm.org/D44810





More information about the llvm-commits mailing list