[PATCH] D44813: Add support for __attribute__(trivial_abi)

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 22 18:55:08 PDT 2018


aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: packages/Python/lldbsuite/test/decorators.py:667
+        return None
+    return skipTestIfFn(compiler_doesnt_support_struct_attribute)
 
----------------
Neat!


================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1011
+        // pass by value is pass by reference, so we ignore that attribute if
+        // set.
+        if (calling_convention == llvm::dwarf::DW_CC_pass_by_value) {
----------------
That is reasonable.


Repository:
  rL LLVM

https://reviews.llvm.org/D44813





More information about the llvm-commits mailing list