[PATCH] D44615: [test] Add test for version scripts with extern C++ and GNU ABI tags.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

"cxx11-tag-version.s" is not an appropriate file name for this test case because this is not specific to C++11. I'd name "extern-cpp.s".



================
Comment at: test/ELF/linkerscript/cxx11-tag-version.s:3
+
+# RUN: echo 'VER1 { global: extern "C++" { returns_string*; accepts_string*; global*; }; local: *; };' > %t.script
+# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
----------------
I think you can remove "VER1".


================
Comment at: test/ELF/linkerscript/cxx11-tag-version.s:8
+
+# CHECK:      Name: _Z14accepts_stringRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE@@VER1
+# CHECK:      Name: _Z14returns_stringB5cxx11v@@VER1
----------------
Remove extraneous space characters between "CHECK:" and "Name:"


================
Comment at: test/ELF/linkerscript/cxx11-tag-version.s:12-25
+.text
+.globl	_Z14returns_stringB5cxx11v
+.type	_Z14returns_stringB5cxx11v, at function
+_Z14returns_stringB5cxx11v:
+
+.text
+.globl	_Z14accepts_stringRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE
----------------
You don't need to repeat the same test case three times. Please use only one symbol.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44615