[PATCH] D44699: [HWASan] Port HWASan to Linux x86-64 (LLVM)

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl added inline comments.


================
Comment at: lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:389
+  if (UntaggedPtr)
+    I->setOperand(getPointerOperandIndex(I), UntaggedPtr);
+
----------------
eugenis wrote:
> I'd move untagging to a separate function. It does not need to be tied to tag checking. In the future we'll probably want to untag other stuff, like pointers in external function call arguments.
> 
Not sure what the future API would be for this function, settled for the most efficient for the current use case.


Repository:
  rL LLVM

https://reviews.llvm.org/D44699