aditya_nandakumar added a comment. > @aditya_nandakumar: You're more familiar with GlobalISel's calling convention code than I am. Do you have any comments on that part? >From a quick glance, it looks good to me.. https://reviews.llvm.org/D44304