[PATCH] D44736: DWARFVerifier: verify debug_names abbreviation table

[Pavel Labath via Phabricator via llvm-commits]

labath added a comment.

In https://reviews.llvm.org/D44736#1045521, @madhur13490 wrote:

> Does this patch covers all planned checks or there are any left which will
>  come later?


There are more to come. In fact, these checks are relatively uninteresting (to me), but I am using it as a foundation for the main check, which is the one that compares the information in the accelerator table with the data I obtain by manually indexing the .debug_info section (I intend to use that to validate the generator by running the verifier on all binaries that I can get my hands on).



================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:970
+
+  if (AttrEnc.Index == DW_IDX_type_hash) {
+    if (AttrEnc.Form != dwarf::DW_FORM_data8) {
----------------
JDevlieghere wrote:
> nit: can we move this above the table initialization? 
sure


Repository:
  rL LLVM

https://reviews.llvm.org/D44736