[PATCH] D44735: [LV] Add TTI::shouldMaximizeVectorBandwidth to allow enabling it per target

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: include/llvm/Analysis/TargetTransformInfo.h:1344
   }
+  bool shouldMaximizeVectorBandwidth(bool OptSize) const override {
+    return Impl.shouldMaximizeVectorBandwidth(OptSize);
----------------
kparzysz wrote:
> craig.topper wrote:
> > Is const needed here? Looking at the nearby methods, it seems only getRegisterBitWidth has it.
> No, it's not needed.  Should I remove it?  What is the best practice here?
Looks like a lot of the methods in here were added by Chandler in one commit without the const. It looks like quite a few at end were added later with const. I didn't scroll down enough before to see them before. const seems more correct. So I guess leave it.


Repository:
  rL LLVM

https://reviews.llvm.org/D44735