[llvm] r328156 - [PDB] Remove unused private variable, re-applying r327900 after relanding more natvis changes[4~

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 21 14:47:26 PDT 2018


Author: rnk
Date: Wed Mar 21 14:47:26 2018
New Revision: 328156

URL: http://llvm.org/viewvc/llvm-project?rev=328156&view=rev
Log:
[PDB] Remove unused private variable, re-applying r327900 after relanding more natvis changes[4~

Modified:
    llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAInjectedSource.h
    llvm/trunk/lib/DebugInfo/PDB/DIA/DIAEnumInjectedSources.cpp
    llvm/trunk/lib/DebugInfo/PDB/DIA/DIAInjectedSource.cpp

Modified: llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAInjectedSource.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAInjectedSource.h?rev=328156&r1=328155&r2=328156&view=diff
==============================================================================
--- llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAInjectedSource.h (original)
+++ llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAInjectedSource.h Wed Mar 21 14:47:26 2018
@@ -19,8 +19,7 @@ class DIASession;
 
 class DIAInjectedSource : public IPDBInjectedSource {
 public:
-  explicit DIAInjectedSource(const DIASession &Session,
-                             CComPtr<IDiaInjectedSource> DiaSourceFile);
+  explicit DIAInjectedSource(CComPtr<IDiaInjectedSource> DiaSourceFile);
 
   uint32_t getCrc32() const override;
   uint64_t getCodeByteSize() const override;
@@ -31,7 +30,6 @@ public:
   std::string getCode() const override;
 
 private:
-  const DIASession &Session;
   CComPtr<IDiaInjectedSource> SourceFile;
 };
 } // namespace pdb

Modified: llvm/trunk/lib/DebugInfo/PDB/DIA/DIAEnumInjectedSources.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/PDB/DIA/DIAEnumInjectedSources.cpp?rev=328156&r1=328155&r2=328156&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/PDB/DIA/DIAEnumInjectedSources.cpp (original)
+++ llvm/trunk/lib/DebugInfo/PDB/DIA/DIAEnumInjectedSources.cpp Wed Mar 21 14:47:26 2018
@@ -30,8 +30,7 @@ DIAEnumInjectedSources::getChildAtIndex(
   if (S_OK != Enumerator->Item(Index, &Item))
     return nullptr;
 
-  return std::unique_ptr<IPDBInjectedSource>(
-      new DIAInjectedSource(Session, Item));
+  return std::unique_ptr<IPDBInjectedSource>(new DIAInjectedSource(Item));
 }
 
 std::unique_ptr<IPDBInjectedSource> DIAEnumInjectedSources::getNext() {
@@ -40,8 +39,7 @@ std::unique_ptr<IPDBInjectedSource> DIAE
   if (S_OK != Enumerator->Next(1, &Item, &NumFetched))
     return nullptr;
 
-  return std::unique_ptr<IPDBInjectedSource>(
-      new DIAInjectedSource(Session, Item));
+  return std::unique_ptr<IPDBInjectedSource>(new DIAInjectedSource(Item));
 }
 
 void DIAEnumInjectedSources::reset() { Enumerator->Reset(); }

Modified: llvm/trunk/lib/DebugInfo/PDB/DIA/DIAInjectedSource.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/PDB/DIA/DIAInjectedSource.cpp?rev=328156&r1=328155&r2=328156&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/PDB/DIA/DIAInjectedSource.cpp (original)
+++ llvm/trunk/lib/DebugInfo/PDB/DIA/DIAInjectedSource.cpp Wed Mar 21 14:47:26 2018
@@ -16,9 +16,8 @@
 using namespace llvm;
 using namespace llvm::pdb;
 
-DIAInjectedSource::DIAInjectedSource(const DIASession &Session,
-                                     CComPtr<IDiaInjectedSource> DiaSourceFile)
-    : Session(Session), SourceFile(DiaSourceFile) {}
+DIAInjectedSource::DIAInjectedSource(CComPtr<IDiaInjectedSource> DiaSourceFile)
+    : SourceFile(DiaSourceFile) {}
 
 uint32_t DIAInjectedSource::getCrc32() const {
   DWORD Crc;




More information about the llvm-commits mailing list