[PATCH] D44735: [LV] Add TTI::shouldMaximizeVectorBandwidth to allow enabling it per target

Hideki Saito via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 21 12:32:29 PDT 2018


hsaito added a comment.

In https://reviews.llvm.org/D44735#1044658, @kparzysz wrote:

> In https://reviews.llvm.org/D44735#1044638, @hsaito wrote:
>
> > I suggest positioning https://reviews.llvm.org/D44735 as a simple refinement of https://reviews.llvm.org/D33341 and then add the above mentioned MinVF adjustment on top, as a separate patch.
> >  Does that work?
>
>
> This plan makes sense to me, but I'm not sure what you mean by the above.  Do you want me to reopen https://reviews.llvm.org/D33341?  The only change there was to enable the flag by default and update failing testcases, I'd like to keep it disabled by default.


By refinement, I meant making it TTI based, keep it disabled by default, and enable it only for your target. Hopefully, that's easy enough for the rest of the community to quickly review/accept and has much lower chances to get reverted.
That alone I think addresses your immediate concerns, and then MinVF adjustment will add additional peace of mind for those targets that need such enforcement.


Repository:
  rL LLVM

https://reviews.llvm.org/D44735





More information about the llvm-commits mailing list