[PATCH] D44713: Unsubmitted part of D44599
David CARLIER via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 21 11:39:37 PDT 2018
devnexen added inline comments.
================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:404
#if SANITIZER_USES_CANONICAL_LINUX_SYSCALLS || SANITIZER_OPENBSD
- return internal_syscall(SYSCALL(unlinkat), AT_FDCWD, (uptr)path, 0);
+ return internal_syscall_ptr(SYSCALL(unlinkat), AT_FDCWD, (uptr)path, 0);
#else
----------------
vitalybuka wrote:
> same for unlinkat, it returns int, on both
>
Seems under Linux it s the same in fact https://github.com/llvm-mirror/compiler-rt/blob/b4e600115ad4c50192095c225aaed3ae9ca99ec1/lib/sanitizer_common/sanitizer_syscall_generic.inc#L53 but I personally do not mind reverting them I think it was kamel who asked me to update in the first place.
https://reviews.llvm.org/D44713
More information about the llvm-commits
mailing list