[PATCH] D41463: [CodeGen] Add a new pass for PostRA sink

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 21 08:17:10 PDT 2018


thegameg added a comment.

In https://reviews.llvm.org/D41463#1043179, @junbuml wrote:

> In my test with Os,  I can see -0.6% in spec2000/gcc, but I couldn't see any change in the hot function (propagate_block), which takes just 11% in profile though.  As far as I check in my environment, 0.6% seems reasonable performance swing. I'm not sure if your regression on 176.gcc could be explained as swing or not. Please let me know you see any negative impact from this.


I took a look at the diffs. Other than very few block placement diffs and some loads using different base registers, everything looks great, so I think this should be fine (I hope I'm not missing anything obvious here). Thank you for the work!


https://reviews.llvm.org/D41463





More information about the llvm-commits mailing list