[PATCH] D44683: [SelectionDAG] Removing FABS folding from DAGCombiner

Mikhail Dvoretckii via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 21 06:15:16 PDT 2018


mike.dvoretsky added a comment.

In https://reviews.llvm.org/D44683#1044354, @arsenm wrote:

> There is supposed to be redundancy between instcombine and dagcombiner. Patterns can appear during lowering that won’t appear in instcombine


If it would be preferred to keep the code, then I could basically recreate https://reviews.llvm.org/D44091 in full. I would note that currently there are no tests in which this pattern is produced specifically in DAG.


https://reviews.llvm.org/D44683





More information about the llvm-commits mailing list