[PATCH] D44728: [dotest] Use subprocess.call to forward arguments in wrapper
Pavel Labath via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 21 03:33:09 PDT 2018
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Thank you. This looks good, assuming that the LLDB_DOTEST_ARGS_STR thingy is working as intended.
================
Comment at: test/lldb-dotest.in:6
dotest_path = '@LLDB_SOURCE_DIR@/test/dotest.py'
-dotest_args = '@LLDB_DOTEST_ARGS_STR@'
+dotest_args_str = '@LLDB_DOTEST_ARGS_STR@'
----------------
I'm confused. Shouldn't this be `@LLDB_DOTEST_ARGS@`, now that you've removed the _STR version?
https://reviews.llvm.org/D44728
More information about the llvm-commits
mailing list