[PATCH] D43005: [ARM] Error out on .arm assembler directives on windows

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

One future refactoring (in a separate patch after this) would be to change all the additions from

  if (TT.isThumb()) {
    if (ARMArchFeature.empty())
      ARMArchFeature = "+thumb-mode,+v4t";
    else
      ARMArchFeature += ",+thumb-mode,+v4t";
  }

into

  if (TT.isThumb()) {
    if (!ARMArchFeature.empty())
      ARMArchFeature += ",";
    ARMArchFeature = "+thumb-mode,+v4t";
  }

But I rather do that change consistently for all three blocks after this patch. (Or are there performance reasons for preferring doing it like it is today?)


https://reviews.llvm.org/D43005