[PATCH] D44717: [InstrProf] Support for external functions in text format.

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: include/llvm/ProfileData/InstrProf.h:430
+
+  static StringRef getExternalSymbol() {
+    return "__llvm_prof_external_symbol__";
----------------
Why do we need to do this? Is it better to return an empty string and skip the entry when it is empty?


================
Comment at: include/llvm/ProfileData/InstrProf.h:479
           IndexedInstrProf::ComputeHash(FuncName), Ins.first->getKey()));
+    Sorted = false;
     return Error::success();
----------------
Sorted = false should be executed only when insertion succeeds.


Repository:
  rL LLVM

https://reviews.llvm.org/D44717