[PATCH] D44702: [llvm-objcopy] Keep the information about the object elf type

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added a comment.

@jakehehrlich, sorry, but i have to disagree with this. As i said before,  initializeSymbol, initializeRelocations are essentially harmful, they break the encapsulation and the separation of concerns,
killing "initialize" in Section* types would make them classes without responsibility (which should not exist) + i would anticipate this would make the issue with duplication even worse 
(because the internals of particular types of sections are tightly related to how they evolve when smth changes are how they are initialized at the first place).  Could you please clarify why you think that ELFtype is not a part of the object, but all the other flags  uint32_t Type; uint32_t Machine; uint32_t Version etc are ? maybe @jhenderson can weigh in. also I assume I might be missing smth.


Repository:
  rL LLVM

https://reviews.llvm.org/D44702