[PATCH] D44469: [llvm-readobj] - Teach llvm-readobj to dump .note.gnu.property sections.

Rafael Avila de Espindola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 20 15:56:58 PDT 2018


espindola accepted this revision.
espindola added a comment.
This revision is now accepted and ready to land.

LGTM with a nit since this is just dumping something that gnu tools are now producing.



================
Comment at: tools/llvm-readobj/ELFDumper.cpp:3547
+    while (Arr.size() >= 8) {
+      uint32_t Type = support::endian::read32(Arr.data(), E);
+      uint32_t DataSize = support::endian::read32(Arr.data() + 4, E);
----------------
This is templated, so use ELFT::Word.


https://reviews.llvm.org/D44469





More information about the llvm-commits mailing list