[PATCH] D44703: [WebAssembly] Strip threadlocal attribute from globals in single thread mode

[Derek Schuff via Phabricator via llvm-commits]

dschuff created this revision.
dschuff added reviewers: sunfish, sbc100.
Herald added subscribers: aheejin, jgravelle-google, jfb.

The default thread model for wasm is single, and in this mode thread-local
global variables can be lowered identically to non-thread-local variables.


Repository:
  rL LLVM

https://reviews.llvm.org/D44703

Files:
  lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp
  test/CodeGen/WebAssembly/tls.ll


Index: test/CodeGen/WebAssembly/tls.ll
===================================================================
--- /dev/null
+++ test/CodeGen/WebAssembly/tls.ll
@@ -0,0 +1,17 @@
+; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt -disable-wasm-explicit-locals -thread-model=single | FileCheck --check-prefix=SINGLE %s
+target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
+target triple = "wasm32-unknown-unknown-wasm"
+
+; SINGLE-LABEL: address_of_tls:
+define i32 @address_of_tls() {
+  ; SINGLE: i32.const $push0=, tls
+  ; SINGLE-NEXT: return $pop0
+  ret i32 ptrtoint(i32* @tls to i32)
+}
+
+; SINGLE: .type	tls, at object
+; SINGLE-NEXT: .section	.bss.tls,"",@
+; SINGLE-NEXT: .p2align 2
+; SINGLE-NEXT: tls:
+; SINGLE-NEXT: .int32 0
+ at tls = internal thread_local global i32 0
Index: lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp
===================================================================
--- lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp
+++ lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp
@@ -126,6 +126,22 @@
 }
 
 namespace {
+class StripThreadLocal final : public ModulePass {
+  // The default thread model for wasm is single, where thread-local variables
+  // are identical to regular globals and should be treated the same. So this
+  // pass just converts all GlobalVariables to NotThreadLocal
+  static char ID;
+
+ public:
+  StripThreadLocal() : ModulePass(ID) {}
+  bool runOnModule(Module &M) override {
+    for (auto &GV : M.globals())
+      GV.setThreadLocalMode(GlobalValue::ThreadLocalMode::NotThreadLocal);
+    return true;
+  }
+};
+char StripThreadLocal::ID = 0;
+
 /// WebAssembly Code Generator Pass Configuration Options.
 class WebAssemblyPassConfig final : public TargetPassConfig {
 public:
@@ -166,10 +182,11 @@
 //===----------------------------------------------------------------------===//
 
 void WebAssemblyPassConfig::addIRPasses() {
-  if (TM->Options.ThreadModel == ThreadModel::Single)
+  if (TM->Options.ThreadModel == ThreadModel::Single) {
     // In "single" mode, atomics get lowered to non-atomics.
     addPass(createLowerAtomicPass());
-  else
+    addPass(new StripThreadLocal());
+  } else
     // Expand some atomic operations. WebAssemblyTargetLowering has hooks which
     // control specifically what gets lowered.
     addPass(createAtomicExpandPass());


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44703.139198.patch
Type: text/x-patch
Size: 2358 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180320/675785e2/attachment.bin>