[PATCH] D44668: [demangler] WIP: Add a "partial" demangling API for LLDB

[Greg Clayton via Phabricator via llvm-commits]

clayborg added inline comments.


================
Comment at: llvm/include/llvm/Demangle/Demangle.h:64
+  /// know this if the function has a cv or reference qualifier.
+  bool isProvablyMemberFunction() const;
+
----------------
erik.pilkington wrote:
> clayborg wrote:
> > s/provably/probably/ in comment and function name. Maybe "couldBeMemberFunction" might be a better name?
> That wasn't a typo, this function checks if the name is for sure a non-static member function, so it conservatively returns false for `a::b()`. I suppose `isDefinitelyMemberFunction()` might be more clear.
Maybe just "isMemberFunction()" would be clear enough? Don't think Definitely needs to be in the name.


Repository:
  rL LLVM

https://reviews.llvm.org/D44668