[PATCH] D44687: [SchedModel] Remove instregex entries that don't match any instructions (WIP)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 20 11:19:07 PDT 2018


RKSimon added a subscriber: bkramer.
RKSimon added inline comments.


================
Comment at: utils/TableGen/CodeGenSchedule.cpp:109
     }
     for (auto &R : RegexList) {
+      int NumMatches = 0;
----------------
craig.topper wrote:
> Do we need two loops here? Why are we building a list of Regexs and the iterating over it?
I haven't looked into the history of this code, although I think @bkramer refactored some of it not so long ago.

I agree that the loops should probably be merged, I'm happy to cleanup this up as long as it doesn't get in the way of people investigating the issues in the models.


Repository:
  rL LLVM

https://reviews.llvm.org/D44687





More information about the llvm-commits mailing list