[lld] r328009 - [ELF] Simplify compCtors and writeInt.

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 20 11:07:26 PDT 2018


Author: maskray
Date: Tue Mar 20 11:07:25 2018
New Revision: 328009

URL: http://llvm.org/viewvc/llvm-project?rev=328009&view=rev
Log:
[ELF] Simplify compCtors and writeInt.

Reviewers: ruiu

Subscribers: emaste, arichardson, llvm-commits

Differential Revision: https://reviews.llvm.org/D44690

Modified:
    lld/trunk/ELF/OutputSections.cpp

Modified: lld/trunk/ELF/OutputSections.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/OutputSections.cpp?rev=328009&r1=328008&r2=328009&view=diff
==============================================================================
--- lld/trunk/ELF/OutputSections.cpp (original)
+++ lld/trunk/ELF/OutputSections.cpp Tue Mar 20 11:07:25 2018
@@ -25,7 +25,6 @@
 using namespace llvm;
 using namespace llvm::dwarf;
 using namespace llvm::object;
-using namespace llvm::support::endian;
 using namespace llvm::ELF;
 
 using namespace lld;
@@ -213,11 +212,11 @@ static void writeInt(uint8_t *Buf, uint6
   if (Size == 1)
     *Buf = Data;
   else if (Size == 2)
-    write16(Buf, Data, Config->Endianness);
+    write16(Buf, Data);
   else if (Size == 4)
-    write32(Buf, Data, Config->Endianness);
+    write32(Buf, Data);
   else if (Size == 8)
-    write64(Buf, Data, Config->Endianness);
+    write64(Buf, Data);
   else
     llvm_unreachable("unsupported Size argument");
 }
@@ -366,8 +365,6 @@ static bool compCtors(const InputSection
   assert(Y.startswith(".ctors") || Y.startswith(".dtors"));
   X = X.substr(6);
   Y = Y.substr(6);
-  if (X.empty() && Y.empty())
-    return false;
   return X < Y;
 }
 




More information about the llvm-commits mailing list