[llvm] r327992 - [X86][Haswell][Znver1] Fix typo in fldl instregexs

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 20 08:44:47 PDT 2018


Author: rksimon
Date: Tue Mar 20 08:44:47 2018
New Revision: 327992

URL: http://llvm.org/viewvc/llvm-project?rev=327992&view=rev
Log:
[X86][Haswell][Znver1] Fix typo in fldl instregexs

Missing comma was casing 2 instregex entries to be concatenated together by mistake.

Found while investigating PR35548

Modified:
    llvm/trunk/lib/Target/X86/X86SchedHaswell.td
    llvm/trunk/lib/Target/X86/X86ScheduleZnver1.td
    llvm/trunk/test/CodeGen/X86/x87-schedule.ll

Modified: llvm/trunk/lib/Target/X86/X86SchedHaswell.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86SchedHaswell.td?rev=327992&r1=327991&r2=327992&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86SchedHaswell.td (original)
+++ llvm/trunk/lib/Target/X86/X86SchedHaswell.td Tue Mar 20 08:44:47 2018
@@ -437,7 +437,7 @@ def : InstRW<[WriteP01], (instregex "ST_
 def : InstRW<[WriteP01], (instregex "LD_F0")>;
 
 // FLDPI FLDL2E etc.
-def : InstRW<[Write2P01], (instregex "FLDPI", "FLDL2(T|E)" "FLDL(G|N)2")>;
+def : InstRW<[Write2P01], (instregex "FLDPI", "FLDL2(T|E)", "FLDL(G|N)2")>;
 
 // FFREE.
 def : InstRW<[WriteP01], (instregex "FFREE")>;

Modified: llvm/trunk/lib/Target/X86/X86ScheduleZnver1.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ScheduleZnver1.td?rev=327992&r1=327991&r2=327992&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ScheduleZnver1.td (original)
+++ llvm/trunk/lib/Target/X86/X86ScheduleZnver1.td Tue Mar 20 08:44:47 2018
@@ -767,7 +767,7 @@ def : InstRW<[ZnWriteFPU13], (instregex
 def : InstRW<[ZnWriteFPU3], (instregex "LD_F1")>;
 
 // FLDPI FLDL2E etc.
-def : InstRW<[ZnWriteFPU3], (instregex "FLDPI", "FLDL2(T|E)" "FLDL(G|N)2")>;
+def : InstRW<[ZnWriteFPU3], (instregex "FLDPI", "FLDL2(T|E)", "FLDL(G|N)2")>;
 
 def : InstRW<[WriteMicrocoded], (instregex "CMOV(B|BE|E|P|NB|NBE|NE|NP)_F")>;
 

Modified: llvm/trunk/test/CodeGen/X86/x87-schedule.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/x87-schedule.ll?rev=327992&r1=327991&r2=327992&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/x87-schedule.ll (original)
+++ llvm/trunk/test/CodeGen/X86/x87-schedule.ll Tue Mar 20 08:44:47 2018
@@ -2872,9 +2872,9 @@ define void @test_fld1_fldl2e_fldl2t_fld
 ; HASWELL:       # %bb.0:
 ; HASWELL-NEXT:    #APP
 ; HASWELL-NEXT:    fld1 # sched: [1:?]
-; HASWELL-NEXT:    fldl2e # sched: [100:0.25]
-; HASWELL-NEXT:    fldl2t # sched: [100:0.25]
-; HASWELL-NEXT:    fldln2 # sched: [100:0.25]
+; HASWELL-NEXT:    fldl2e # sched: [1:0.50]
+; HASWELL-NEXT:    fldl2t # sched: [1:0.50]
+; HASWELL-NEXT:    fldln2 # sched: [1:0.50]
 ; HASWELL-NEXT:    fldpi # sched: [1:0.50]
 ; HASWELL-NEXT:    fldz # sched: [1:0.50]
 ; HASWELL-NEXT:    #NO_APP
@@ -2932,9 +2932,9 @@ define void @test_fld1_fldl2e_fldl2t_fld
 ; ZNVER1:       # %bb.0:
 ; ZNVER1-NEXT:    #APP
 ; ZNVER1-NEXT:    fld1 # sched: [11:1.00]
-; ZNVER1-NEXT:    fldl2e # sched: [100:?]
-; ZNVER1-NEXT:    fldl2t # sched: [100:?]
-; ZNVER1-NEXT:    fldln2 # sched: [100:?]
+; ZNVER1-NEXT:    fldl2e # sched: [11:1.00]
+; ZNVER1-NEXT:    fldl2t # sched: [11:1.00]
+; ZNVER1-NEXT:    fldln2 # sched: [11:1.00]
 ; ZNVER1-NEXT:    fldpi # sched: [11:1.00]
 ; ZNVER1-NEXT:    fldz # sched: [8:0.50]
 ; ZNVER1-NEXT:    #NO_APP




More information about the llvm-commits mailing list