[PATCH] D27296: Don't assume mingw is providing SSP functions

Valentin Churavy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 20 08:27:42 PDT 2018


vchuravy added a comment.

In https://reviews.llvm.org/D27296#1042876, @mstorsjo wrote:

> Sorry about that - I tested it with a build tree that was a couple weeks old. For some reason I got that failure there, but it does indeed seem to work with the latest trunk version. No idea what changed inbetween.


No worries!

> Do you have commit access, or do you want me to commit it for you?

I don't have commit access so it would be great if you could land this.

You are right about Itanium. I will switch to `not isWindowsGNUEnvironment()` for the test and add a minimal test case for IA64.


Repository:
  rL LLVM

https://reviews.llvm.org/D27296





More information about the llvm-commits mailing list