[PATCH] D44676: [SCEV] Make exact taken count calculation more optimistic

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:6672
+  const BasicBlock *Latch = L->getLoopLatch();
+  // All exits we have collected must dominate the only latch.
+  if (!Latch)
----------------
mkazantsev wrote:
> mkazantsev wrote:
> > fhahn wrote:
> > > With exits you mean "exiting blocks", rather than "exit blocks", right? (http://lists.llvm.org/pipermail/llvm-dev/2017-July/115962.html)
> > > 
> > >  Maybe it would be clearer to explicitly use "exiting blocks" instead of exits here (and throughout the patch) :)
> > > 
> > Sure, I will fix it. :)
> Actually I can do it as a separate NFC. This is not the only place where the term is used.
Sounds good to me. 


https://reviews.llvm.org/D44676