[polly] r327216 - Add isl operator overloads for isl::pw_aff

Michael Kruse via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 20 03:58:30 PDT 2018


2018-03-17 7:34 GMT+01:00 Tobias Grosser <tobias at grosser.es>:
> On Sat, Mar 17, 2018, at 00:34, Michael Kruse wrote:,
>> Shouldn't such changes go through a review?
>
> In retrospective, it certainly should. At least one issue slipped in (see below). Would you mind doing a post-commit review or should I revert and put it on phab?

I am primarily interested in a review to discuss whether this is the
direction to go. It is the difference between whether Polly is a
personal or community project. We could, e.g. assume that overloads
will eventually be part of isl C++ bindings, instead of every user of
isl needing its own overloads. I know we had this discussion on
isl-development already, but AFAIK we did not come to a conclusion.

However, I am personally fine with adding such overloads. The C++
bindings are currently now part of isl anyway.

Michael


More information about the llvm-commits mailing list