[PATCH] D27296: Don't assume mingw is providing SSP functions

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 20 00:10:10 PDT 2018


mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D27296#1042387, @vchuravy wrote:

> Hm I can't reproduce the failure you are seeing.


Sorry about that - I tested it with a build tree that was a couple weeks old. For some reason I got that failure there, but it does indeed seem to work with the latest trunk version. No idea what changed inbetween.

> I added your example as a test case and started extending the tests in `Codegen/X86/stack-protector.ll` to also cover mingw (there still lots of cases to go there).

Thanks, this looks great!

Do you have commit access, or do you want me to commit it for you?


Repository:
  rL LLVM

https://reviews.llvm.org/D27296





More information about the llvm-commits mailing list