[PATCH] D44599: OpenBSD UBsan support missing bits

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

I've submitted everything except https://reviews.llvm.org/D44651



================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:315
 #elif SANITIZER_USES_CANONICAL_LINUX_SYSCALLS
-  return internal_syscall(SYSCALL(newfstatat), AT_FDCWD, (uptr)path,
+  return internal_syscall_ptr(SYSCALL(newfstatat), AT_FDCWD, (uptr)path,
                           (uptr)buf, 0);
----------------
Could you please create another patch for _ptr


================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:339
+#elif SANITIZER_FREEBSD || SANITIZER_OPENBSD
   return internal_syscall(SYSCALL(fstatat), AT_FDCWD, (uptr)path,
+                         (uptr)buf, AT_SYMLINK_NOFOLLOW);
----------------
should we use _ptr here?


================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:1759
+  *pc = 0;
+  *bp = 0;
+  *sp = 0;
----------------
Why zeroes?
Could you please create new patch with real values?


Repository:
  rL LLVM

https://reviews.llvm.org/D44599