[PATCH] D41463: [CodeGen] Add a new pass for PostRA sink

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg added a comment.

Thanks for this @junbuml! I did some runs on arm64 and I see a regression on 176.gcc, in average of 1.5%.

I'm comparing

`-Os -mllvm -disable-postra-machine-sink`
vs
`-Os`

I did 6 runs for both configs and compared all of them:

  176.gcc   1.4%
  176.gcc   1.3%
  176.gcc   1.3%
  176.gcc   0.9%
  176.gcc   0.5%
  176.gcc   0.6%
  176.gcc   1.2%
  176.gcc   1.1%
  176.gcc   1.1%
  176.gcc   0.7%
  176.gcc   0.3%
  176.gcc   0.4%
  176.gcc   1.4%
  176.gcc   1.2%
  176.gcc   1.2%
  176.gcc   0.8%
  176.gcc   0.4%
  176.gcc   0.6%
  176.gcc   2.4%
  176.gcc   2.3%
  176.gcc   2.3%
  176.gcc   1.9%
  176.gcc   1.5%
  176.gcc   1.6%
  176.gcc   2.5%
  176.gcc   2.4%
  176.gcc   2.4%
  176.gcc   1.9%
  176.gcc   1.6%
  176.gcc   1.7%
  176.gcc   2.6%
  176.gcc   2.5%
  176.gcc   2.5%
  176.gcc   2.1%
  176.gcc   1.7%
  176.gcc   1.8%

I will investigate to see if I can find anything if I'm the only one seeing this.



================
Comment at: lib/CodeGen/MachineSink.cpp:970
+getSingleLiveInSuccBB(MachineBasicBlock &CurBB,
+                      ArrayRef<MachineBasicBlock*>  SinkableBBs,
+                      unsigned Reg, const TargetRegisterInfo *TRI) {
----------------
Should be `ArrayRef<MachineBasicBlock *> SinkableBBs`


https://reviews.llvm.org/D41463