[PATCH] D44521: [InstSimplify] fp_binop X, NaN --> NaN

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 19 12:33:06 PDT 2018


spatel added a comment.

In https://reviews.llvm.org/D44521#1041564, @nhaehnle wrote:

> In https://reviews.llvm.org/D44521#1041180, @spatel wrote:
>
> > Do you mean bitcast back and forth? Example:
>
>
> Yes, except I don't see how end up with `-1.0` as inline constant in the v_add. Here's what I get, which looks more correct:
>
>   s_load_dwordx2 s[4:5], s[0:1], 0x24
>   s_load_dword s0, s[0:1], 0x2c
>   s_mov_b32 s7, 0xf000
>   s_mov_b32 s6, -1
>   s_waitcnt lgkmcnt(0)
>   s_add_i32 s0, s0, -1
>   v_mov_b32_e32 v0, s0
>   buffer_store_dword v0, off, s[4:7], 0
>   s_endpgm
>   


Yes - I must've copy-pasted the wrong chunk here. I updated all of the AMDGPU tests other than the f64 ones to be independent of this patch:
https://reviews.llvm.org/rL327890
https://reviews.llvm.org/rL327891


https://reviews.llvm.org/D44521





More information about the llvm-commits mailing list