[PATCH] D44625: Accept any filepath in llvm_check_source_file_list

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM with the comments addressed.



================
Comment at: cmake/modules/LLVMProcessSources.cmake:84-89
     get_filename_component(fn ${g} NAME)
     if(ARG_SOURCE_DIR)
       set(entry "${g}")
     else()
       set(entry "${fn}")
     endif()
----------------
You should be able to delete this entire block now.


================
Comment at: cmake/modules/LLVMProcessSources.cmake:99
         if( idx LESS 0 )
-          message(SEND_ERROR "Found unknown source file ${g}
+          message(SEND_ERROR "Found unknown source file ${gp}
 Please update ${CMAKE_CURRENT_LIST_FILE}\n")
----------------
It's more friendly to display the relative path to the source directory here, rather than the full path.


https://reviews.llvm.org/D44625