[PATCH] D44549: allow-multiple-definitions should completely suppress errors instead of making them warnings.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 19 11:04:21 PDT 2018
ruiu added inline comments.
================
Comment at: lld/ELF/SymbolTable.cpp:515
replaceSymbol<Defined>(S, &F, Name, Binding, StOther, Type, 0, 0, nullptr);
- else if (Cmp == 0)
+ else if (Cmp == 0 && !Config->AllowMultipleDefinition)
reportDuplicate(S, &F);
----------------
espindola wrote:
> Please leave the check for AllowMultipleDefinition in reportDuplicate. Both overloads should check it or none.
>
Done.
https://reviews.llvm.org/D44549
More information about the llvm-commits
mailing list