[PATCH] D44509: Remove unnecessary includes from lld/ELF

[David Blaikie via llvm-commits]

On Mon, Mar 19, 2018 at 9:59 AM Rafael Avila de Espindola via Phabricator <
reviews at reviews.llvm.org> wrote:

> espindola added a comment.
>
> Some of these seem to be really unused (mutex in InputSection.cpp).
>
> Ideally we would remove just those.  Given that this changes just cpp
> files, I am somewhat tempted to LGTM this. If we want to avoid indirect
> includes, how dependable is IWYU these days?


Not sure - I think some of the folks at Google are still really aiming to
build something more reliable based on modules, etc.


> Would the bots doing module builds find any problems?
>

Some problems - though I think the modules builds only modularize the
public (include/*) headers, not implementation headers.


>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D44509
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180319/41d337ec/attachment.html>