[PATCH] D44544: llvm-objdump: Print symbol name if it's address is the same as the next one's

Rafael Avila de Espindola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 19 10:02:06 PDT 2018


espindola accepted this revision.
espindola added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D44544#1039975, @t.p.northover wrote:

> > Why is this better?
>
> I know I've hit aliased functions in the past and had to run `nm` or something to find out where they are instead of just grepping the disassembly. So I'm definitely in favour.


As a compromise, LGTM if you first report a bug on GNU objdump so that we find out if they have any rationale for printing only one of the symbols.


https://reviews.llvm.org/D44544





More information about the llvm-commits mailing list