[PATCH] D42762: Rewrite the VS Integration Scripts

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 19 09:46:07 PDT 2018


zturner added a comment.

In https://reviews.llvm.org/D42762#1041034, @chandlerc wrote:

> FYI, Andrew Pardoe from Microsoft and I were talking and he wanted to express really strong support for getting this in and deployed. He's also offered any help that would be useful to sorting this out so there is a solid installer for VS 2017.
>
> Anything this is waiting on (since it already got an LGTM some time ago)?


I think the biggest reason I've been dragging my feet on this is that there was never really a strong consensus that this was the right direction, and I don't feel great about committing without consensus.  I guess I was subconsciously hoping someone else would show up and chime in with their opinion.  Part of the problem is that there's not many LLVM developers who are also VS users, and of the ones that actually are, most are VS users of CMake generated projects as opposed to VS users of hand-maintained projects.  And that is ultimately who we are targeting with this VS integration, so it would be good to have their feedback.

But since it looks like that probably isn't gonna happen, I guess I can wait until the end of this week and see if the discussion magically picks up again.  If not, I suppose I can commit as-is at the end of the week.


https://reviews.llvm.org/D42762





More information about the llvm-commits mailing list