[PATCH] D43781: Make AddrSpaceCast noops on PPC

[Valentin Churavy via Phabricator via llvm-commits]

vchuravy marked an inline comment as done.
vchuravy added a comment.

Thanks! Can you land this for me I don't have the commit bit.



================
Comment at: test/CodeGen/PowerPC/addrspacecast.ll:1
+; RUN: llc -mtriple=powerpc64le-unknown-linux-gnu %s -o /dev/null
+
----------------
nemanjai wrote:
> I'm not sure how `/dev/null` works for targets I'm not familiar with (like Windows). Is this a common thing to do?
> It might not be a terrible thing to actually do `< %s | FileCheck %s` and then maybe just a `CHECK-LABEL` to verify we've actually generated assembly.
> 
> But in either case, I assume that `lit` checks for the return code from the `llc` invocation, so I'm fine either way.
Yeah this seems fairly standard and was taken from the `ARM/addrspacecast.ll`
But I can use FileCheck and CHECK-LABEL to do the same


Repository:
  rL LLVM

https://reviews.llvm.org/D43781