[PATCH] D40146: [JumpThreading] Preservation of DT and LVI across the pass

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/trunk/lib/Transforms/Scalar/JumpThreading.cpp:2610
+  // the above calls to update Dominators.
+  DDT->applyUpdates(
+      {// Guarded block split.
----------------
I think DuplicateInstructionsInSplitBetween can easily update the DT itself: D44629. Is it better to do the update incrementally here or make DuplicateInstructionsInSplitBetween take care of it (via splitBlock)? Letting functions update the DT themselves seems to be what similar functions do.

We do not have access to the plain DT here though, which makes that slightly trickier and that's why I want to check what's better before doing any changes here :)


Repository:
  rL LLVM

https://reviews.llvm.org/D40146