[PATCH] D44554: [SCEV] Factor out isKnownViaInduction. NFC.

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev accepted this revision.
mkazantsev added a comment.
This revision is now accepted and ready to land.

LGTM with nits. We also have method `isKnownOnEveryIteration` which, I believe, is a weaker version of this one. We should consider replacing of it with this one I think.



================
Comment at: lib/Analysis/ScalarEvolution.cpp:8724
+    return false;
+  // It is possible that init SCEV contains an invariant load but it does
+  // not dominate MDL and is not available at MDL loop entry, so we should
----------------
Assert that `SplitLHS.second` and `SplitRHS.second` are also not `getCouldNotCompute()` at this point?


================
Comment at: lib/Analysis/ScalarEvolution.cpp:8731
+
+  return isLoopEntryGuardedByCond(MDL, Pred, SplitLHS.first,
                                        SplitRHS.first) &&
----------------
Please clang-format that.


https://reviews.llvm.org/D44554