[PATCH] D42377: [CodeGen] Use MIR syntax for MachineMemOperand printing

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 18 13:58:39 PDT 2018


thegameg added inline comments.


================
Comment at: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp:428
+static void printMemOperand(raw_ostream &OS, const MachineMemOperand &MMO,
+                            const SelectionDAG *G) {
+  const MachineFunction &MF = G->getMachineFunction();
----------------
craig.topper wrote:
> G isn't guaranteed non-null here. There's a version of SDNode::dump() that passes nullptr. This is most often used when debugging in gdb/lldb. Though I found a use in the X86 backend that I fixed in r327744.
Sorry about that. Put up a patch to fix this: https://reviews.llvm.org/D44611.


Repository:
  rL LLVM

https://reviews.llvm.org/D42377





More information about the llvm-commits mailing list