[PATCH] D44488: [llvm-mca] Refactor class RegisterFile to allow the definition of multiple register files.
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 18 07:00:36 PDT 2018
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM with a couple of minors
================
Comment at: tools/llvm-mca/Dispatch.cpp:30
+ unsigned NumTemps) {
+ unsigned RegisterFileIndex = RegisterFiles.size();
+ RegisterFiles.emplace_back(NumTemps);
----------------
Assert that RegisterFileIndex < 32 ? There may be other cases but this is the only one that I can find.
================
Comment at: tools/llvm-mca/Dispatch.h:42
+ // renaming. A value of zero for this field means: this register file has
+ // an unbound number of registers.
+ const unsigned TotalMappings;
----------------
unbounded
https://reviews.llvm.org/D44488
More information about the llvm-commits
mailing list