[PATCH] D44598: [lit] Add line numbers for RUN commands to shell code

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In https://reviews.llvm.org/D44598#1041038, @delcypher wrote:

> Your description of needing to pass `-vv` doesn't look accurate, doesn't the test case just pass `-v`?


Hi Dan,

Thanks for your question, and sorry for the confusion.  The existing test case isn't a good example as it exercises a test parse error rather than a normal failed RUN command.  When using the external shell, -vv is indeed needed.  When using the internal shell, -v would be sufficient... except I have a bug in that case.

I'm about to update the diff with new tests that should hopefully demonstrate the new feature better.  It will also fix this feature for the internal shell.


https://reviews.llvm.org/D44598