[PATCH] D44274: Object: Fix handling of @@@ in .symver directive
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 16 16:05:43 PDT 2018
pcc added inline comments.
================
Comment at: llvm/test/LTO/X86/symver-asm3.ll:8
+target triple = "x86_64-unknown-linux-gnu"
+
+module asm "_start1:"
----------------
I'd also add a test where the definition is in IR.
================
Comment at: llvm/test/LTO/X86/symver-asm3.ll:20
+; CHECK-DAG: t foo@@SOME_VERSION1
+; CHECK-DAG: t foo at SOME_VERSION2
+; CHECK-DAG: t foo@@SOME_VERSION3
----------------
Is this right? I thought it should be `U foo at SOME_VERSION2`.
https://reviews.llvm.org/D44274
More information about the llvm-commits
mailing list