[PATCH] D44546: [SelectionDAG] Transfer DbgValues when integer operations are promoted

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: test/DebugInfo/AArch64/dbg-value-i8.ll:8
+; When ISel promotes the result of i8 add, the attached dbg.value shouldn't be dropped.
+; CHECK: DEBUG_VALUE: bar:t
+; Function Attrs: nounwind
----------------
Can you run llc as `llc -stop-after=livedebugvariables` and check for a DBG_VALUE instead? This should make the test more robust.


================
Comment at: test/DebugInfo/AArch64/dbg-value-i8.ll:29
+
+attributes #0 = { nounwind "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="generic" "target-features"="+neon" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="generic" "target-features"="+neon" "unsafe-fp-math"="false" "use-soft-float"="false" }
----------------
Please remove all attributes that are not necessary to reproduce the test. (Usually everything in quotes).


https://reviews.llvm.org/D44546