[PATCH] D43996: [llvm-objcopy] Implement support for .group sections.

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: tools/llvm-objcopy/Object.cpp:281
   if (Symbols == Sec) {
-    error("Symbol table " + Symbols->Name + " cannot be removed because it is "
-                                            "referenced by the relocation "
-                                            "section " +
+    error("Symbol table " + Symbols->Name +
+          " cannot be removed because it is "
----------------
jhenderson wrote:
> jakehehrlich wrote:
> > I realize this might look a little strange but it's what clang-format does if I recall correctly. I want this to be whatever clang-format makes it not what actually looks nice. Changing how this error message is generated to make it look nice would be an improvement though.
> @alexshap, can you confirm that you've clang-formatted this bit here, like @jakehehrlich pointed out?
yes, that's what clang-format currently does
(clang-format -i -style=llvm Object.cpp)


Repository:
  rL LLVM

https://reviews.llvm.org/D43996