[PATCH] D43624: Change DEBUG() macro to LLVM_DEBUG()

[Jakub Kuderski via Phabricator via llvm-commits]

kuhar added a comment.

In https://reviews.llvm.org/D43624#1040260, @Nicola wrote:

> I understand the concern, that's why I checked the "main" projects: libcxx, lld, compiler-rt and lldb and none of them use the macro. clang is the only one that does (as far as I can tell)
>  Which other projects should I be checking?


>From the top of my head definitely Polly uses it. I'd make sure by cloning the git monorepo and doing a quick grep over it.

> There are (were, at least?) clashes with other open source projects, such as MESA: https://lists.freedesktop.org/archives/mesa-dev/2016-July/124111.html and they ended up renaming DEBUG into MESA_DEBUG to avoid clashing with LLVM.

I see, thank you for the link.

> I did think about leaving the old DEBUG macro around, that would make things easier on the breakage side. The issue is that we would need a way to deprecate the macro so that people stop using it and switch to the new one.
>  We could have a transition period in which we have both macros, but the "old" DEBUG macro should eventually be removed.

Well, worst case we could just announce it deprecated on the mailing list.


https://reviews.llvm.org/D43624