[PATCH] D7775: [IR] Avoid the need to prefix MS C++ symbols with '\01'
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 16 12:59:05 PDT 2018
rnk added a comment.
I hadn't considered switching just Windows to MM_None, that's is an interesting idea. Usually Windows has the most bugs involving '\01' because of how prevalent it is on Windows, but if we do MM_None that will all go away, and only Darwin will suffer them. =p
================
Comment at: llvm/lib/IR/Mangler.cpp:146
+ MSFunc = nullptr;
+ Prefix = '\0';
+ }
----------------
espindola wrote:
> You don't need to set Prefix in here, just MSFunc. With that you also don't need the {}.
Yep, will do.
https://reviews.llvm.org/D7775
More information about the llvm-commits
mailing list