[PATCH] D42659: [COFF] Clarify comment. NFC

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

Super belated ping.



================
Comment at: COFF/Writer.cpp:577
+  // PE/COFF images are limited to 8 byte section names. Longer names can be
+  // supported by writing a non-standard string table, but this string table is
+  // not mapped at runtime and the long names will therefore be inaccessible.
----------------
mstorsjo wrote:
> Not sure about non-standard though, since iirc dumpbin at least shows them correctly - so the extension is at least acknowledged by MS that much.
It's non-standard in the sense that the spec explicitly says "Executable images do not use a string table and do not support section names longer than 8 characters." My guess is that dumpbin either doesn't specialize the string table reading logic for executables (i.e. it just uses the same logic for object files and executables), or they explicitly allow it to play better with binutils. Either way, I think non-standard is a fair way to put it.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42659