[PATCH] D44570: [dwarf] Unify unknown dwarf enum formatting code

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: include/llvm/BinaryFormat/Dwarf.h:597
+    if (Str.empty()) {
+      OS << "DW_" << dwarf::EnumTraits<Enum>::Type << "_Unknown_"
+         << llvm::format("%x", E);
----------------
labath wrote:
> JDevlieghere wrote:
> > Is the capitalization of Unknown on purpose (to differentiate with valid enum values)?
> That's what the existing code was doing. I personally have no preference for either..
I lean slightly towards lowercase because it's more consistent. 


Repository:
  rL LLVM

https://reviews.llvm.org/D44570